Question

In coding a traditional MVC application, what is the best practice for coding server-side form validations? Does the code belong in the controller, or the model layer? And why?

Was it helpful?

Solution

From Wikipedia:

Model-view-controller (MVC) is an architectural pattern used in software engineering. Successful use of the pattern isolates business logic from user interface considerations, resulting in an application where it is easier to modify either the visual appearance of the application or the underlying business rules without affecting the other. In MVC, the model represents the information (the data) of the application and the business rules used to manipulate the data; the view corresponds to elements of the user interface such as text, checkbox items, and so forth; and the controller manages details involving the communication to the model of user actions such as keystrokes and mouse movements.

Thus, model - it holds the application and the business rules.

OTHER TIPS

I completely agree with Josh. However you may create a kind of validation layer between Controller and Model so that most of syntactical validations can be carried out on data before it reaches to model.

For example,

The validation layer would validate the date format, amount format, mandatory fields, etc...

So that model would purely concentrate on business validations like x amount should be greater than y amount.

My experience with MVC thus far consists of entirely rails.

Rails does it's validation 100% in the Model.
For the most part this works very well. I'd say 9 out of 10 times it's all you need.

There are some areas however where what you're submitting from a form doesn't match up with your model properly. There may be some additional filtering/rearranging or so on.

The best way to solve these situations I've found is to create faux-model objects, which basically act like Model objects but map 1-to-1 with the form data. These faux-model objects don't actually save anything, they're just a bucket for the data with validations attached.
An example of such a thing (in rails) is ActiveForm

Once the data gets into those (and is valid) it's usually a pretty simple step to transfer it directly across to your actual models.

The basic syntax check should be in the control as it translates the user input for the model. The model needs to do the real data validation.

Licensed under: CC-BY-SA with attribution
Not affiliated with StackOverflow
scroll top