SQL Server 'Execute As'/Revert pattern in a 'Try/Catch' Block
-
14-04-2022 - |
Question
I wish to ensure I am using the "best" pattern when using an Execute As/Revert from within a Try/Catch block on SQL Server 2012. The below code "seems" to behave correctly... Am I missing anything or are there any security concerns, "better" approaches, etc.?
Below is my code:
CREATE PROCEDURE [dbo].[TryItOut]
WITH EXECUTE as 'NoTable1Access' --does not have access (select) to Table1!
AS
Begin
Declare @execErrorNumber int,
@execErrorMessage nvarchar(2048),
@xactState smallint
Begin Try
Execute as user='HasTable1Access'
select *, 1/0 as [SimulateError] from [T1].[Table1]; -- This will be a Stored Procedure call, but a select statement was easier to demo...
Revert --Revert on 'HasTable1Access'
End Try
Begin Catch;
select @execErrorNumber = ERROR_NUMBER(),
@execErrorMessage = ERROR_MESSAGE(),
@xactState = XACT_STATE();
Revert -- Revert on 'HasTable1Access' when in error...
--Do some error processing in context of 'NoTable1Access'
End Catch
select * from [T1].[Table1] --Should NOT have any access now and select should fail...
End
No correct solution
Licensed under: CC-BY-SA with attribution
Not affiliated with StackOverflow