Python 'return not' statement in subprocess returncode

Question

I just came across a very strange line of code in Python:

....
self.myReturnCode = externalProcessPopen.returncode
....
....
return not self.myReturnCode
....

What exactly return not stands for? I am aware that the returncode of a Popen process is None while it's still running and a random number once it completes and exits successfully. But what exactly is the author of the code trying to achieve here?

It might also be worth noting that the same author later on checks the return code like this:

if not testClass.testFunction():
    logger.error('Failed to execute Function')
    ....

Answer 1

not is a boolean operator that returns the boolean inverse of the value. return returns the result of that operator. In other words, the expression should be read as return (not self.myReturnCode). Quoting the documentation:

The operator not yields True if its argument is false, False otherwise.

If self.myReturnCode is a true value, not self.myReturnCode is False, and vice versa. Note that self.myReturnCode can be any Python value, but not always returns a boolean value, either True or False.

If externalProcessPopen.returncode is the return code of an external process, then it'll be a positive integer if the process exited with an error, 0 if it exited successfully. This is called the process exit status; what non-zero values are returned depends entirely on the process. not 0 is then True, not 1 (or a higher integer value) gives you False.

If it is None, then True (not None is True) would be returned as well, but a subprocess.Popen() return code is only None if the process has not yet exited.

Answer 2

return not self.myReturnCode

is to be interpreted as:

return (not self.myReturnCode)

What it is doing in your code is simply this:

• If the returncode is 0 then return True
• If the returncode is not 0 then return False.

Answer 3

return not self.myReturnCode

is equivalent to:

return False if self.myReturnCode else True

Answer 4

It wouldn't be a random number, it's the return code of the external process, where zero indicates success and a non-zero number indicates failure.

Hence returning not self.myReturnCode means it returns True when the process was successful and False when the process indicated failure.