CppCheck: Variable 'bla' is not assigned a value

StackOverflow https://stackoverflow.com/questions/5321979

  •  24-10-2019
  •  | 
  •  

Question

running CppCheck over my codebase produces some style warnings. E.g. in 

void foo(int& x)
{
  x = 0; 
}
void bar()
{
  int y;
  foo(y);
}

it gives me 

Variable 'y' is not assigned a value

It's the same with code like

 char buffer[160];
 i+=sprintf(buffer,"%2.2ld.",ymd.monthday);

Is this a problem with my code or is it a problem with CppCheck? (How) should I fix it?

Thanks for any thoughts!

Was it helpful?

Solution

It's a bug in CppCheck and the good news is that it has already been fixed!

You can either grab the latest code and build your own version or wait for v1.48 to be released. Version 1.48 is planned to be released on April 9th according to the wiki.

OTHER TIPS

It is a problem of CppCheck. Your code is fine (at least the given one).

You are using the variable y as an 'out' parameter, but CppCheck is not able to determine that. It is better to initialize the y at the time of definition with int y = 0; so that in future if somebody tries to use the parameter x in foo they will not get uninitialized value.

Licensed under: CC-BY-SA with attribution
Not affiliated with StackOverflow
scroll top