Question

This is a homework assignment, to estimate the square root of a number input by the user, using Newton's method, which should return a result of < .0001. When I run the code and enter a number, nothing happens after that. In debug mode, the 'value' increases, which is the opposite of what I want it to do. Thanks in advance.

import java.text.DecimalFormat;
import java.util.Scanner;

public class Newton {

    public static void main(String[] args) 
      {
        // declare a Scanner class object
        Scanner sc = new Scanner(System.in);
        // declare a DecimalFormat class object
        DecimalFormat fourDecimal =  new DecimalFormat("0.0000");

        float Number = 0;

        System.out.println("Program: find square roots by Newton's Method");
        System.out.println("Please enter a number: ");

        Number = sc.nextFloat();

        System.out.println("The square root of " + Number + " is " + fourDecimal.format(Compute(Number)));
        }

    public static float Compute(float Number)
    {
    // define variable sqrRoot to hold the approximate square root
    float sqrRoot = 0;
    // define temporary variable temp to hold prior value of iteration
    float temp = 0;
    // divide variable num by 2 to start the iterative process
    // and assign the quotient to temp
    temp = Number/2;
    // open a while() loop that continues as long as num >= 0.0
    while (Number >= 0.0)
    {
    // construct the main iterative statement
        sqrRoot = temp - (temp * temp - Number) / (2 * temp);
    // open an if block to check if the absolute value of the difference of
    // variables temp and sqrRoot is below a small sentinel value such as 0.0001
    // if this condition is true then break the loop
        float value;
        value = Math.abs(temp - sqrRoot);
        if (value < .0001)
            // return sqrRoot as the answer
            Number = sqrRoot;
            // if this condition is not true then assign sqrRoot to temp
            else temp = sqrRoot;

    // close the while() loop
    }
    return Number;  
    }
}
Was it helpful?

Solution

Your loop will not terminate because your condition is

while (Number >= 0.0)

That would be OK if you actually exited the function when your condition is met:

   if (value < .0001)
        // return sqrRoot as the answer
        return sqrRoot;

So - change that last line and it will work.

Demo : http://ideone.com/XzJXLv

public static float Compute(float Number)
{
    // define variable sqrRoot to hold the approximate square root
    float sqrRoot = 0;
    // define temporary variable temp to hold prior value of iteration
    float temp = 0;
    // divide variable num by 2 to start the iterative process
    // and assign the quotient to temp
    temp = Number/2;

    // open a while() loop that continues as long as num >= 0.0
    while (Number >= 0.0)    // <<<< you might reconsider this condition: iteration count?
    {
        // construct the main iterative statement
        sqrRoot = temp - (temp * temp - Number) / (2 * temp);

        // open an if block to check if the absolute value of the difference of
        // variables temp and sqrRoot is below a small sentinel value such as 0.0001
        // if this condition is true then break the loop
        float value;
        value = Math.abs(temp - sqrRoot);

        if (value < .0001)
            // return sqrRoot as the answer
            return sqrRoot;  // <<<<< this is the line you needed to change
        // if this condition is not true then assign sqrRoot to temp
        else temp = sqrRoot;
    } // close the while() loop

    return Number;  // <<<<< you will never reach this line
}

OTHER TIPS

The huge tables of square roots used by engineers and schoolchildren prior to the 1970s have now been replaced by a five-line program for Newton’s method.

public static Number squareRoot(Number value) {
    double temp = value.doubleValue() / 2;
    for(double sqrRoot; ; temp = sqrRoot) {
        sqrRoot = temp - (temp * temp - value.doubleValue()) / (2 * temp);
        if (Math.abs(temp - sqrRoot) < 1e-10) return sqrRoot;
    }
}
Licensed under: CC-BY-SA with attribution
Not affiliated with StackOverflow
scroll top