Question

I'm developing an app that requires multiple passwords to access varying data areas. For example, a group of people could set up a chat that requires password authentication to view.

Here's how I'm considering doing it:

I have my keyword, let's say hypothetically:

Banana

When the user enters their password, I use RNCryptor to encrypt Banana using their entered key, and store that encrypted string to the server.

Later, when someone tries to enter a password, I take the hashed value from the server and try to decrypt it using the password they entered as a key. If the decrypted value equals Banana I know they entered the correct password.

I'm new to security, so I'm not sure if this would be an appropriate solution. All help is appreciated.

Update

After making some alterations suggested by @Greg and the aptly named @Anti-weakpasswords, here's what I have:

- (NSDictionary *) getPasswordDictionaryForPassword:(NSString *)password {

    NSData * salt = [self generateSalt256];
    NSData * key = [RNCryptor keyForPassword:password salt:salt settings:mySettings];

    NSMutableDictionary * passwordDictionary = [NSMutableDictionary new];

    NSString * saltString = stringFromData(salt);
    NSString * keyString = stringFromData(key);

    passwordDictionary[@"key"] = keyString;
    passwordDictionary[@"salt"] = saltString;
    passwordDictionary[@"version"] = @"1.0.0";
    passwordDictionary[@"iterationCount"] = @"10000";

    return passwordDictionary;
}

static const RNCryptorKeyDerivationSettings mySettings = {
    .keySize = kCCKeySizeAES256,
    .saltSize = 32,
    .PBKDFAlgorithm = kCCPBKDF2,
    .PRF = kCCPRFHmacAlgSHA1,
    .rounds = 10000
};

- (NSData *)generateSalt256 {
    unsigned char salt[32];
    for (int i=0; i<32; i++) {
        salt[i] = (unsigned char)arc4random();
    }
    NSData * dataSalt = [NSData dataWithBytes:salt length:sizeof(salt)];
    return dataSalt;
}
Was it helpful?

Solution

  • Do not use a single pass of any hashing function to store passwords.
  • Do not fail to use a random salt in the 8-16 byte range.
  • Do not use reversible encryption to store passwords.
  • Do not use the password precisely as entered as your encryption key.

Instead, when the user is selecting a keyword/passphrase

  • Generate a cryptographically random 8-16 byte salt
  • Use PBKDF2, BCrypt, or SCrypt with said salt and as large an iteration count/work factor as your processors can handle to create a password hash
    • If you use PBKDF2 in specific, do not request a larger output than the native hash size (SHA-1 = 20 bytes, SHA-256 is 32 bytes, SHA-384 is 48 bytes, and SHA-512 is 64 bytes), or you increase the comparative advantage an attacker has over you, the defender.

Then in your database, you store that user's particular:

  • Salt in the clear
  • Iteration count/work factor
    • So you can easily change/upgrade it later
  • Resulting password hash
  • Version of authentication protocol - this would be 2, probably, or 1.
    • So you can easily change/upgrade it later if you move from this method to NewWellKnownMethod later

When the user wants to authenticate to your system, you:

  • Retrieve their version, salt, iteration count/work factor, and resulting hash from the database
  • Hash whatever keyword/password they just entered with the salt and iteration count/work factor from the database.
  • Compare the result you just got with what was in the database; if they're the same, let them in.
    • Advanced: use a constant time compare, so it doesn't just quit trying if the first byte is different, to reduce the vulnerability to timing attacks.

Please read How to securely hash passwords?, of which Thomas Porrin's answer is currently the most commonly referred to Stackexchange treatise on password hashing, and certainly the best I've seen so far.

OTHER TIPS

It's not good way of doing that. You should use one way hash algorithm to hash the password (you won't be able to decrypt it). After you hash the password you save it to database after the user provide password you have to hash it and compare it (the hash value) with the hash you store in database. If it matches it means it's the same if not the authentication failed.

In that way even if someone gain access to the database the data will be secured, he won't do anything with that, it's not password stored there.

Most of the authentication is made that way.

//Extended

You should use some hash algorithm made for this kind of job.

Check out SHA or MD5

Licensed under: CC-BY-SA with attribution
Not affiliated with StackOverflow
scroll top