Question

Since today, my login controller (using Sentry) doesn't work anymore. I already changed it 10203902 times but it keeps giving me the error: "a [login] attribute is required". For the past 2-3 weeks this controller worked fine.

LoginController

 <?php namespace Digitus\Auth\Controllers;

use Illuminate\View\Environment as View;
use Cartalyst\Sentry\Sentry;
use Illuminate\Support\Facades\Input;
use Illuminate\Routing\Redirector as Redirect;

class LoginController extends \Digitus\Base\Controllers\BController{

    public function __construct(Input $input, View $view, Sentry $sentry, Redirect $redirect){
        $this->input    = $input;
        $this->view     = $view;
        $this->sentry   = $sentry;
        $this->user     = $this->sentry->getUser();
        $this->redirect = $redirect;

        if($this->sentry->check()) {
            $user = $this->sentry->getUser();
        } else {
            $user = null;
        }
        $this->view->share('loggedUser', $user);
    }

    protected $input;
    protected $view;
    protected $sentry;
    protected $redirect;

    public function index()
    {
        return $this->view->make('user.login');
    }

    public function login()
    {
        $user = $this->user->where('username', $this->input->get('email_or_username'))->orWhere('email', $this->input->get('email_or_username'))->first();
        $credentials = array(
            'email' => Input::get('email_or_username') ?: null,
            'password' => $this->input->get('password'),
        );
        try {
            $user = $this->sentry->authenticate($credentials, false);

            if($this->sentry->check())
            {
                return $this->redirect->to('admin');
            } else {
                return $this->redirect->to('');
            }
        }
        catch (\Exception $e)
        {
            return $this->redirect->to('login')->withErrors(array('login'=> $e->getMessage()));
        }
    }

}

View

@extends('layouts.main')

@section('content')

<div class="col-md-4 col-md-offset-4">
    <div class="panel panel-info">
        <div class="panel-heading">PLease Login</div>
        <div class="panel-body">
            {{ Form::open(array('url' => 'login')) }}
            @if($errors->has('login'))
                <div class="alert alert-danger">
                    <a href="#" class="close" data-dismiss="alert">&times;</a>
                    {{ $errors->first('login', ':message') }}
                </div>
            @endif
            <div class="form-group">
                {{ Form::label('email_or_username', 'Email Address or Username') }}
                {{ Form::email('email_or_username', '', array('class'=>'form-control','placeholder'=>'Please enter your Email Address or Username to login', 'autofocus')) }}
            </div>
            <div class="form-group">
                {{ Form::label('password', 'Password') }}
                {{ Form::password('password', array('class'=>'form-control', 'placeholder'=>'Password')) }}
            </div>
            <div class="form-group">
                {{ Form::submit('Login', array('class'=>'btn btn-success')) }}
                {{ HTML::link('/', 'Cancel', array('class'=>'btn btn-danger')) }}
            </div>
            <hr>
            <div class="form-group">
                <h2>Don't have an account?</h2>
                {{ HTML::link('register', 'Please register here', array('class'=>'btn btn-primary btn-xs'))}}
            </div>
            {{ Form::close() }}
        </div>
    </div>
</div>

@stop

I've already asked many people for solutions or fixes etc. They all didn't work..

PS & FYI: I also published the Sentry config, and the login_attribute is email. Any help or input would be great. Thanks in advance..

Was it helpful?

Solution

Sentry also uses the

protected static $loginAttribute = 'email';

To get the login data, check if you have made changes to it. Those are the lines that are giving you a hard time:

$loginName = $this->userProvider->getEmptyUser()->getLoginName();

$loginCredentialKey = (isset($credentials[$loginName])) ? $loginName : 'login';

Basically if $loginAttribute is not available it will use 'login' as the credential key. So you can also test to give what it wants:

$credentials = array(
    'email' => Input::get('email_or_username') ?: null,
    'login' => Input::get('email_or_username') ?: null,
    'password' => $this->input->get('password'),
);

Unfortunately, you cannot have two different fields to login your user, so if you need this you'll have to do your check manually, so you probably will be able to do something like:

public function login()
{
    $user = $this->sentry->getUserProvider()->getEmptyUser();

    $user = $user->where('email', $this->input->get('email_or_username'))
                        ->orWhere('username', $this->input->get('email_or_username'))
                        ->first();

    try 
    {
        if ($user && Hash::check($this->input->get('password'), $user->password)) /// here you check if a user was found
        {
            $this->sentry->login($user, false); /// remember = false /// here is the login happening in case of true
        }
        else
        {
            // user not found or wrong password
        }
    }
    catch (\Exception $e)
    {
        return $this->redirect->to('login')->withErrors(array('login'=> $e->getMessage()));
    }
}
Licensed under: CC-BY-SA with attribution
Not affiliated with StackOverflow
scroll top