Question

I made this program to order data sets and display the max, min, average, and median. Originally I had everything in main, I decided to clean it up a bit by making functions. The average function was working fund but after adding a few more the value returned for average in 'nan. Any suggestions? Thanks in advance guys

#include <stdio.h>

int findSize();
double findAverage(int size, double num[]);
double findMedian(int size, double num[]);
void findLowtoHigh(int size, double num[]);
void findHightoLow(int size, double num[]);

int main()
{
 while(1)
 {
  int size = findSize();

  if(size <= 1)
  {
   return 0;
  }

  double num[size];
  double holder;
  double lowest;
  double highest;
  double average;
  double median;

  fprintf(stdout, "\n"); 

  for(int i = 0; i <= size - 1; i++)
  {
   int j = i+1;
   fprintf(stdout, "Please enter number %d: ", j);
   fscanf(stdin, "%lf", &num[i]);
  }

  if(size > 1)
  {
   for(int y = 0; y < size - 1; y++)
   { 
    for(int k = 0; k < size - 1; k++)
    {
     if(num[k] > num[k+1])
     { 
      holder = num[k];
      num[k] = num[k+1];
      num[k+1] = holder;
     }
    }
   }
  }

  findLowtoHigh(size, num);

  findHightoLow(size, num);

  average = findAverage(size, num);

  median = findMedian(size, num);

  fprintf(stdout, "\n\nLowest Value: %3.4f", num[0]);
  fprintf(stdout, "\nHighest Value: %3.4f", num[size-1]);
  fprintf(stdout, "\n\nAverage Value: %3.4f\n", average);  
  fprintf(stdout, "Median Value: %3.4f", median);

  fprintf(stdout, "\n");
 }

}

int findSize()
{
 int size;

 fprintf(stdout, "\nPlease enter size of the array: ");
 scanf("%d", &size);

 return size;
}

void findLowtoHigh(int size, double num[])
{
 fprintf(stdout, "\nFrom least to greatest: ");

 for(int x = 0; x <= size - 1; x++)
 {
  fprintf(stdout, "%3.2f ", num[x]);
 }
}

void findHightoLow(int size, double num[])
{
 fprintf(stdout, "\nFrom greatest to least: ");

 int reverse = size - 1;

 while(reverse != -1)
 {
  fprintf(stdout, "%3.2f ", num[reverse]);
  reverse--;
 }
}

double findAverage(int size, double num[])
{
 double average;

 for(int a = 0; a <= size - 1; a++)
 {
  average = average + num[a];
 }

 average = average / size;

 return average;
} 

double findMedian(int size, double num[])
{
 double median;

 if(size % 2 == 0)
 {
  median = (num[size/2 - 1] + num[size/2])/2;
 }
 else
 {
  median = num[size/2];
 }

 return median;
}
Was it helpful?

Solution

You have to initialize average. Change to

double average=0;

OTHER TIPS

Compile your prrogram with (mild) optimization and all reasobnable warnings turned on (gcc -O -Wall is a starting point on Linux, clang is similar), and check (and fix!) all complaints by the compiler. Only then are you allowed to ask the 'net.

Licensed under: CC-BY-SA with attribution
Not affiliated with StackOverflow
scroll top