Field shadowed by local variable from the point of view of an anonymous class [duplicate]

Question

This question already has answers here:

access to variable within inner class in java (5 answers)

How to access shadowed Outer class variable from Inner class? (3 answers)

Closed 9 years ago.

I'm trying to run this code:

class A {
  int x = 123;
  public void f(int x) {
    new Runnable() {
      public void run() {
        System.out.println(x);
      }
    }.run();
  }
  static {
    A a = new A();
    a.f(33);
  }
}

But it's giving me an error:

$ javac A.java && java A
A.java:6: local variable x is accessed from within inner class; needs to be declared final
        System.out.println(x);
                           ^
1 error

The x argument isn't final, so it shouldn't be accessible from the anonymous class, yet the code fails to compile. It looks like the println line is trying to use the x argument instead of the x field. Why? How can I tell it I want the x field?

Answer 1

You can use

A.this.x

Since the anonymous Runnable class is an inner class of the A class.

The concept of shadowing determines that x in

System.out.println(x);

is referring to the local method parameter variable x, but that is not final so you can't access it within the anonymous class, not in Java 7 and below at least. You can in Java 8, which may be confusing.

_{Don't use the same name for your variables in the same compilation unit.}