Question

I'm trying to read a matrix from a file and store it in an allocated 2D Array.

But it's just reading the first 3 or 4 numbers and the rest gets read as a garbage.

This is my code:

#include<stdio.h>
#include<stdlib.h>
#include<stdbool.h>


int main()
{
FILE *inputFile1;
FILE *inputFile2;
FILE *outputFile1;
int i,j,k;

int rows1,cols1,rows2,cols2;

char fileName[100];
bool fileFound=false;

bool multiplcation = true;

int sum=0;

do
{
    printf("Enter File name of matrix #1 - with extention - : ");
    scanf("%[^\n]%*c",fileName);
    inputFile1 = fopen(fileName,"r");
    if(!inputFile1)
    {
            printf("File Not Found!!\n");
            fileFound=true;
    }
    else
        fileFound=false;

}while(fileFound);


do
{
    printf("Enter File name of matrix #2 - with extention - : ");
    scanf("%[^\n]%*c",fileName);
    inputFile2 = fopen(fileName,"r");
    if(!inputFile2)
    {
            printf("File Not Found!!\n");
            fileFound=true;
    }
    else
        fileFound=false;

}while(fileFound);

fscanf(inputFile1,"%i",&rows1);
fscanf(inputFile1,"%i",&cols1);
fscanf(inputFile2,"%i",&rows2);
fscanf(inputFile2,"%i",&cols2);

printf("\n\nRows1 = %d",rows1);
printf("\nCols1 = %d",cols1);
printf("\n\nRows2 = %d",rows2);
printf("\nCols2 = %d",cols2);


if(cols1!=rows2)
    multiplcation=false;
else
    multiplcation=true;

if(multiplcation==false)
{
    printf("Cant multiply those two matrices \n");
    fclose(inputFile1);
    fclose(inputFile2);
    return 0;
}

else
{
    //allocate Matrcies

    int **mat1 = (int **)malloc(rows1 * sizeof(int*));
    for(i = 0; i < rows1; i++)
        mat1[i] = (int *)malloc(cols1 * sizeof(int));

    i=0;

    int **mat2 = (int **)malloc(rows2 * sizeof(int*));
    for(i = 0; i < rows2; i++)
        mat2[i] = (int *)malloc(cols2 * sizeof(int));

    i=0;

    int **mat3 = (int **)malloc(rows1 * sizeof(int*));
    for(i = 0; i < rows1; i++)
        mat3[i] = (int *)malloc(cols2 * sizeof(int));

    i=0;


    while(!feof(inputFile1))
    {
        for(i=0;i<rows1;i++)
        {
            for(j=0;j<cols1;j++)
                fscanf(inputFile1,"%d%*[^\n]%*c",&mat1[i][j]);
        }
    }

    i=0;
    j=0;

    while(!feof(inputFile2))
    {
        for(i=0;i<rows2;i++)
        {
            for(j=0;j<cols2;j++)
                fscanf(inputFile2,"%d%*[^\n]%*c",&mat2[i][j]);
        }
    }

    /////////////////////////
    i=0;
    j=0;
    printf("\n\n");
    //print matrix 1
    for(i=0;i<rows1;i++)
    {
        for(j=0;j<cols1;j++)
            printf("%d\t",mat1[i][j]);

        printf("\n");
    }
    ////////////////////////////
    i=0;
    k=0;
    printf("\n\n");
    //print matrix 2
    for(i=0;i<rows2;i++)
    {
        for(j=0;j<cols2;j++)
            printf("%d\t",mat2[i][j]);

        printf("\n");
    }
    /////////////////////////
    i=0;
    j=0;
    //multiplication stetments
    for(i=0;i<rows1;i++)
    {
        for(j=0;j<cols2;j++)
        {
            sum=0;
            for(k=0;k<rows2;k++)
                sum+=mat1[i][k]*mat2[k][j];
        }
        mat3[i][j]=sum;
    }

    i=0;
    j=0;
    k=0;

    //print multiplication result
    printf("\n\nResult = \n\n");

    for(i=0;i<rows1;i++)
    {
        for(j=0;j<cols2;j++)
            printf("%d\t",mat3[i][j]);

        printf("\n");
    }


    fclose(inputFile1);
    fclose(inputFile2);
}

}

My first file is like this:

    4 3
    1 2 3
    2 3 1
    3 1 2
    1 3 2

My second file is like this:

    3 4
    1 2 3 1
    2 1 2 3
    3 1 3 2

Can anyone help me?

Was it helpful?

Solution

Just using %d or %i fixed the issue for me, but we will need your full code to be able to help you if this doesn't resolve your issue.

fscanf(inputFile1, "%d", &mat1[i][j]);
Licensed under: CC-BY-SA with attribution
Not affiliated with StackOverflow
scroll top