Random Math Java Program Showing Incorrect Answers

Question

My program generates radnom math problems. Onclick it shows the answer to the math problems.

Every answer is wrong and I cannot figure out what the relevance of the numbers shown as answers is.

Here is the full program,

Driver Class

import java.awt.EventQueue;
import java.awt.GridLayout;
import java.awt.event.*;

import javax.swing.*;

public class Driver extends MathProblems {

    MathProblems problems = new MathProblems();

    String s = "Welcome Students!";
    String b = "Start!";
    private JFrame f;
    private JPanel p;

    JFrame frame = new JFrame();

    JButton b1 = new JButton(b);

    JLabel jl = new JLabel(s);

    int i;

    public Driver () {      
        gui();  
    }

    public void gui() { 
        f = new JFrame("Flash Card Program");       
        p = new JPanel();   
        f.setLayout( new GridLayout( 2, 1 ) );
        f.add(jl);
        f.add(p);
        p.setLayout( new GridLayout( 2, 1 ) );
        p.add(b1);

        jl.setHorizontalAlignment(JLabel.CENTER);

        // pack the frame for better cross platform support
        f.pack();
        // Make it visible
        f.setVisible(true);
        f.setSize(560,400); // default size is 0,0
        f.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);


        b1.addActionListener(new ActionListener() {
            public void actionPerformed(ActionEvent e){
                if(b1.getText().equals("Click For Answer"))
                {
                    problems.run();
                    jl.setText(problems.toString());
                    b = "Next Question";
                    b1.setText(b);
                }
                else
                {
                    problems.run();
                    jl.setText(problems.getQuestion());
                    b = "Click For Answer";
                    b1.setText(b);

                }
            }
        });
    }


    public static void main(String[] args) {
        EventQueue.invokeLater(new Runnable() {
           public void run() {
                new Driver();
           }
        });
    } // End main Method

} // End class Driver

MathProblems Class

import java.util.Random;

public class MathProblems {
     private static final int MAX_NUMBER = 10;
     private static final Random random = new Random();

     private int expected = 0;
     private String question = "";

     public void run() {
         final int a = random.nextInt(MAX_NUMBER);
         final int b = random.nextInt(MAX_NUMBER);

         final int type = random.nextInt(4);

         switch (type) {
             case 0: 
                 add(a, b);
                 break;
             case 1: 
                subtract(a, b);
                break;
             case 2:
                multiply(a, b);
                break;
             case 3:
                 divide(a, b);
                 break;
         }
     }

     private void add(final int a, final int b) {
         expected = a + b;

         askQuestion(a + " + " + b + " = ");
     }

     private void subtract(final int a, final int b) {
         expected = a - b;

         askQuestion(a + " - " + b + " = ");
     }

     private void multiply(final int a, final int b) {
         expected = a * b;

         askQuestion(a + " * " + b + " = ");
     }

     private void divide(final int a, final int b) {
         expected = a / b;

         askQuestion(a + " / " + b + " = ");
     }

     private  void askQuestion(final String question) {
         this.question = question;
     }  

     public String getQuestion() {
         return question;
     }

     public int getAnswer() {
         return expected;
   }

     @Override
     public String toString(){
     return Integer.toString(expected);
     }
}

Answer 1

Change this,

  b1.addActionListener(new ActionListener() {
            public void actionPerformed(ActionEvent e){
                if(b1.getText().equals("Click For Answer"))
                {
                    problems.run();
                    jl.setText(problems.toString());
                    b = "Next Question";
                    b1.setText(b);
                }
                else
                {
                    problems.run();
                    jl.setText(problems.getQuestion());
                    b = "Click For Answer";
                    b1.setText(b);

                }
            }
        });

To this,

       b1.addActionListener(new ActionListener() {
                public void actionPerformed(ActionEvent e){
                    if(b1.getText().equals("Click For Answer"))
                    {

                        jl.setText(problems.toString());
                        b = "Next Question";
                        b1.setText(b);
                    }
                    else
                    {
                        problems.run();
                        jl.setText(problems.getQuestion());
                        b = "Click For Answer";
                        b1.setText(b);

                    }
                }
            });

Answer 2

when your jframe calls problems.run() below, it is generating a new problem and displaying the answer for that problem.

            if(b1.getText().equals("Click For Answer"))
            {
                problems.run();
                jl.setText(problems.toString());
                b = "Next Question";
                b1.setText(b);
            }

Answer 3

I suspect the problem is here:

if(b1.getText().equals("Click For Answer")) { 
   problems.run(); 
   jl.setText(problems.toString()); 
   b = "Next Question";
   b1.setText(b); 
}

I guess you want to display the answer but you regenerate the problem first. Remove the call to problems.run().