Singleton desing pattern issue in iphone sdk
Question
I have integrated evernote in my application by downloading sample code from its site. It otherwise works fine, only that it has a singleton class which contains static values of username and password. The .h file of this class looks like this
extern NSString * const username;
extern NSString * const password;
@interface Evernote : NSObject {
Evernote *sharedEvernoteManager;
}
in .m file
NSString * const username = @"username";
NSString * const password = @"password";
@implementation Evernote
/************************************************************
*
* Connecting to the Evernote server using simple
* authentication
*
************************************************************/
- (void) connect {
if (authToken == nil)
{
// In the case we are not connected we don't have an authToken
// Instantiate the Thrift objects
NSURL * NSURLuserStoreUri = [[[NSURL alloc] initWithString: userStoreUri] autorelease];
THTTPClient *userStoreHttpClient = [[[THTTPClient alloc] initWithURL: NSURLuserStoreUri] autorelease];
TBinaryProtocol *userStoreProtocol = [[[TBinaryProtocol alloc] initWithTransport:userStoreHttpClient] autorelease];
EDAMUserStoreClient *userStore = [[[EDAMUserStoreClient alloc] initWithProtocol:userStoreProtocol] autorelease];
// Check that we can talk to the server
bool versionOk = [userStore checkVersion: applicationName :[EDAMUserStoreConstants EDAM_VERSION_MAJOR] : [EDAMUserStoreConstants EDAM_VERSION_MINOR]];
if (!versionOk) {
// Alerting the user that the note was created
UIAlertView *alertDone = [[UIAlertView alloc] initWithTitle: @"Evernote" message: @"Incompatible EDAM client protocol version" delegate: self cancelButtonTitle: @"Ok" otherButtonTitles: nil];
[alertDone show];
[alertDone release];
return;
}
// Returned result from the Evernote servers after authentication
EDAMAuthenticationResult* authResult =[userStore authenticate:username :password : consumerKey :consumerSecret];
// User object describing the account
self.user = [authResult user];
// We are going to save the authentication token
self.authToken = [authResult authenticationToken];
// and the shard id
self.shardId = [user shardId];
// Creating the user's noteStore's URL
noteStoreUri = [[[NSURL alloc] initWithString:[NSString stringWithFormat:@"%@%@", noteStoreUriBase, shardId] ] autorelease];
// Creating the User-Agent
UIDevice *device = [UIDevice currentDevice];
NSString * userAgent = [NSString stringWithFormat:@"%@/%@;%@(%@)/%@", applicationName,applicationVersion, [device systemName], [device model], [device systemVersion]];
// Initializing the NoteStore client
THTTPClient *noteStoreHttpClient = [[[THTTPClient alloc] initWithURL:noteStoreUri userAgent: userAgent timeout:15000] autorelease];
TBinaryProtocol *noteStoreProtocol = [[[TBinaryProtocol alloc] initWithTransport:noteStoreHttpClient] autorelease];
noteStore = [[[EDAMNoteStoreClient alloc] initWithProtocol:noteStoreProtocol] retain];
}
}
I need to make the username and password dynamic so that I can use values from textfields as follows
NSString * const username = usernametextfiled.text;
NSString * const password = passwrdfiled.text;
I am getting error that says we cannot add text field before @implementation. How to solve this issue?
Solution
@interface Evernote : NSObject
...
@property(retain) NSString * username;
@property(retain) NSString * password;
then
@implementation Evernote
@synthesize username;
@synthesize password;
then you can set them using
[[Evernote sharedEvernoteManager]setusername:yourvariable];
[[Evernote sharedEvernoteManager]setpassword:yourvariable];
do remember to release the variable in dealloc
Licensed under: CC-BY-SA with attribution
Not affiliated with StackOverflow