Question

i have a null pointer exception in my computePaths() method, please help me find the reason why. below is my code and below my code is the output i have

Vertex class:

class Vertex implements Comparable<Vertex> {
    String name;
    Double minDistance = Double.POSITIVE_INFINITY;
    Vertex previous;
    Edge[] adjacencies;

    public String toString() {
        return name;
    }

    public Vertex(String argName) {
        name = argName;
    }

    @Override
    public int compareTo(Vertex other) {
        return Double.compare(minDistance, other.minDistance);
    }

}

Edge class:

class Edge {
    Double weight;
    Vertex target;

    public Edge(Vertex argTarget, Double argWeight) {
        target = argTarget;
        weight = argWeight;
    }
}

Class for the algorithm:

public class BellmanFord {
    public static void computePaths(Vertex source, Vertex[] vertices) {
        source.minDistance = 0.0;
        PriorityQueue<Vertex> vq = new PriorityQueue<Vertex>();
        vq.add(source);

        for (int i = 1; i < vertices.length - 1; i++) {

            while (!vq.isEmpty()) {

                Vertex u = vq.poll();
                for (Edge e : u.adjacencies) {
                    Vertex v = e.target;
                    System.out.println(u + " " + e.target);
                    Double weight = e.weight;
                    Double distanceThroughU = u.minDistance + weight;
                    if (distanceThroughU < v.minDistance) {
                        vq.remove(v);
                        v.minDistance = distanceThroughU;
                        v.previous = u;
                        vq.add(v);
                    }
                }
            }
        }
    }

    public static List<Vertex> getShortestPathTo(Vertex target) {
        List<Vertex> path = new ArrayList<Vertex>();
        for (Vertex v = target; v != null; v = v.previous) {
            path.add(v);
        }
        Collections.reverse(path);
        return path;
    }

    public static void main(String[] args) {
        Vertex a = new Vertex("A");
        Vertex b = new Vertex("B");
        Vertex c = new Vertex("C");
        Vertex d = new Vertex("D");
        Vertex e = new Vertex("E");

        a.adjacencies = new Edge[] { new Edge(b, -1.0), new Edge(c, 4.0) };
        b.adjacencies = new Edge[] { new Edge(d, 2.0), new Edge(c, 3.0), new Edge(e, 2.0) };
        d.adjacencies = new Edge[] { new Edge(b, 1.0) };
        e.adjacencies = new Edge[] { new Edge(d, -3.0) };

        Vertex[] vertices = { b, c, d, e };
        computePaths(a, vertices);

        for (Vertex v : vertices) {
            System.out.println(" distance to " + v.toString() + " is " + v.minDistance);
            System.out.println("path is " + getShortestPathTo(v));
        }
    }
}

and here is my output

A B
A C
B D
B C
B E
D B
E D
D B
Exception in thread "main" java.lang.NullPointerException
    at BellmanFord.computePaths(BellmanFord.java:50)
    at BellmanFord.main(BellmanFord.java:106)

so line 50 is for(Edge e : u.adjacencies) and line 106 is computePaths(a,vertices);

Was it helpful?

Solution

NPE should be thrown because you haven't initialized the adjacencies in c Vertex reference. But, you have passed the vertices array to computePaths method with c.adjacencies as null

OTHER TIPS

it was my fault, in my code, i commented out this line of code c.adjacencies = new Edge[]{ new Edge(c, 0.0)};, so the for loop in my computePath() method was short of 1 vertices. It works now. Thanks for help.

Licensed under: CC-BY-SA with attribution
Not affiliated with StackOverflow
scroll top