Can I pass an arbitrary block of commands to a bash function?

Question

I am working on a bash script where I need to conditionally execute some things if a particular file exists. This is happening multiple times, so I abstracted the following function:

function conditional-do {
    if [ -f $1 ]
    then
        echo "Doing stuff"
        $2
    else
        echo "File doesn't exist!"
    end
}

Now, when I want to execute this, I do something like:

function exec-stuff {
    echo "do some command"
    echo "do another command"
}
conditional-do /path/to/file exec-stuff

The problem is, I am bothered that I am defining 2 things: the function of a group of commands to execute, and then invoking my first function.

I would like to pass this block of commands (often 2 or more) directly to "conditional-do" in a clean manner, but I have no idea how this is doable (or if it is even possible)... does anyone have any ideas?

Note, I need it to be a readable solution... otherwise I would rather stick with what I have.

Answer 1

This should be readable to most C programmers:

function file_exists {
  if ( [ -e $1 ] ) then 
    echo "Doing stuff"
  else
    echo "File $1 doesn't exist" 
    false
  fi
}

file_exists filename && (
  echo "Do your stuff..."
)

or the one-liner

file_exists filename && echo "Do your stuff..."

Now, if you really want the code to be run from the function, this is how you can do that:

function file_exists {
  if ( [ -e $1 ] ) then 
    echo "Doing stuff"
    shift
    $*
  else
    echo "File $1 doesn't exist" 
    false
  fi
}

file_exists filename echo "Do your stuff..."

I don't like that solution though, because you will eventually end up doing escaping of the command string.

EDIT: Changed "eval $*" to $ *. Eval is not required, actually. As is common with bash scripts, it was written when I had had a couple of beers ;-)

Answer 2

One (possibly-hack) solution is to store the separate functions as separate scripts altogether.

Answer 3

The cannonical answer:

[ -f $filename ] && echo "it has worked!"

or you can wrap it up if you really want to:

function file-exists {
    [ "$1" ] && [ -f $1 ]
}

file-exists $filename && echo "It has worked"