No it's not illegal, but arguments starting with - are usually interpreted as command line switches.
You can use the -- command line switch to tell most such programs to not interpret the following arguments as command line switches.
ln -s -- ./local--pdf-kundendienst -pdf-kundendienst