onItemClicklistner(); does'nt work for Custom listView in android

Question

I have a custom listView.xml having a listView as.

    <?xml version="1.0" encoding="utf-8"?>
<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:background="@null" >

    <ListView
        android:id="@+id/searchList"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:layout_below="@+id/txtSearchFor"
        android:background="@color/Black" >
    </ListView>

</RelativeLayout>

this listview contains an ImageView, 2 TextViews and a RatingBar (item_list.XML) as given below.

    <?xml version="1.0" encoding="utf-8"?>
<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="match_parent"
    android:layout_height="match_parent" >
    <RelativeLayout
        android:id="@+id/rel_SearchLayout01"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:layout_alignParentLeft="true"
        android:layout_alignParentTop="true" >

        <ImageView
            android:id="@+id/img_searchBookCoverPhoto"
            android:layout_width="70dp"
            android:layout_height="100dp"
            android:layout_margin="5dp"
            android:background="@drawable/rounded_image_borders"
            android:focusable="false"
            android:src="@drawable/book1" />

        <TextView
            android:id="@+id/txt_searchBookTitle"
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
            android:layout_alignTop="@+id/img_searchBookCoverPhoto"
            android:layout_marginTop="10dp"
            android:layout_toRightOf="@+id/img_searchBookCoverPhoto"
            android:focusable="false"
            android:text="The Basic Doctrine Of Islam"
            android:textColor="@color/White"
            android:textSize="16sp" />

        <TextView
            android:id="@+id/txt_searchAutherName"
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
            android:layout_below="@+id/txt_searchBookTitle"
            android:layout_marginTop="2dp"
            android:layout_toRightOf="@+id/img_searchBookCoverPhoto"
            android:focusable="false"
            android:text="By: Andrew J Newman"
            android:textColor="@color/SkyBlue"
            android:textSize="14sp" />

        <RatingBar
            android:id="@+id/searchRatingbar"
            style="?android:attr/ratingBarStyleSmall"
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
            android:layout_below="@+id/txt_searchAutherName"
            android:layout_marginTop="12dp"
            android:layout_toRightOf="@+id/img_searchBookCoverPhoto"
            android:focusable="false"
            android:isIndicator="false"
            android:numStars="5"
            android:rating="5"
            android:stepSize="1" />
    </RelativeLayout>

</RelativeLayout>

• My question is that i have a click event for Listview as shown below

but its not working, i m really amazed, why this is happening

As you can see that i have set this also

android:focusable="false"

for all view inside my custom listView.

here is code of custom adapter also.

public class BookSearchResultActivity extends Activity {

    static final String URL = "http://www.shiaislamiclibrary.com/requesthandler.ashx";
    static final String KEY_ITEM = "Book"; // parent node
    static final String KEY_BOOKAUTHOR = "BookAuthor";
    static final String KEY_BOOKTITLE = "BookTitle";
    static final String KEY_BOOKCODE = "BookCode";
    static final String KEY_BOOKIMAGE = "BookImage";

    ArrayList<String> BookTitle = new ArrayList<String>();
    ArrayList<String> BookCoverPhotos = new ArrayList<String>();
    ArrayList<String> BookAuther = new ArrayList<String>();
    ArrayList<String> ImageByte = new ArrayList<String>();
    ArrayList<Bitmap> bitmapArray = new ArrayList<Bitmap>();

    ListView lv;
    ListView listView;
    Activity act = this;

    LayoutInflater inflater = null;

    TextView txtSearchedKeywords;
    TextView txtSearchFor;
    TextView txtBooksCount;
    String keyWordsSearch;
    String language;

    URL bookImageURL = null;
    Bitmap bitMapImage = null;
    Context context = BookSearchResultActivity.this;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        // TODO Auto-generated method stub
        super.onCreate(savedInstanceState);
        setContentView(R.layout.book_search_layout);

        txtSearchedKeywords = (TextView) findViewById(R.id.txtKeyWordSearched);
        txtSearchFor = (TextView) findViewById(R.id.txtSearchFor);
        txtBooksCount = (TextView) findViewById(R.id.txtNmbrOfBooksFound);
        listView = (ListView) findViewById(R.id.searchList);

        Intent getInfoIntent = getIntent();
        keyWordsSearch = getInfoIntent.getStringExtra("SEARCH_KEYWORDS");
        language = getInfoIntent.getStringExtra("LANG");

        ConnectivityManager cm = (ConnectivityManager) getSystemService(Context.CONNECTIVITY_SERVICE);
        // checking for availbe internet Connection
        if (cm.getActiveNetworkInfo() != null
                && cm.getActiveNetworkInfo().isAvailable()
                && cm.getActiveNetworkInfo().isConnected()) {

            new UIThread().execute(URL, keyWordsSearch, language);

        }

        listView.setChoiceMode(ListView.CHOICE_MODE_SINGLE);
        listView.setOnItemClickListener(new AdapterView.OnItemClickListener() {
            @Override
            public void onItemClick(AdapterView<?> arg0, View arg1, int pos,
                    long arg3) {
                Toast.makeText(context, BookTitle.get(pos).toString(),
                        Toast.LENGTH_SHORT).show();
            }
        });
    }

    private class UIThread extends AsyncTask<String, Integer, String> {

        ProgressDialog progressDialog;

        @Override
        protected void onPreExecute() {
            // TODO Auto-generated method stub
            super.onPreExecute();
            progressDialog = ProgressDialog.show(getParent(),
                    "Search in Progress...",
                    "This may Take a few seconds.\nPlease Wait...");

            txtSearchFor.setText("Searching in Progress...!");
            txtBooksCount.setVisibility(View.INVISIBLE);

        }

        @Override
        protected String doInBackground(String... params) {

            String URL = params[0];
            String searchKeywords = params[1];

            XMLParser parser = new XMLParser();
            String XMLString = parser.getXmlFromUrl(URL, searchKeywords,
                    language);
            // Log.i("XML Response", XMLString);

            Document doc = parser.getDomElement(XMLString);

            NodeList nl = doc.getElementsByTagName(KEY_ITEM);

            // looping through all item nodes <item>
            for (int i = 0; i < nl.getLength(); i++) {
                Element e = (Element) nl.item(i);

                BookTitle.add(parser.getValue(e, KEY_BOOKTITLE));
                BookCoverPhotos.add("http://shiaislamicbooks.com/books_Snaps/"
                        + parser.getValue(e, KEY_BOOKCODE) + "/1_thumb.jpg");
                BookAuther.add(parser.getValue(e, KEY_BOOKAUTHOR));
                Log.i("URLs", BookCoverPhotos.toString());
            }
            for (int i = 0; i < BookAuther.size(); i++) {

                try {
                    bookImageURL = new URL(BookCoverPhotos.get(i));
                } catch (MalformedURLException e) {
                    e.printStackTrace();
                    Log.i("URL", "ERROR at image position" + i + "");
                }

                try {
                    bitMapImage = BitmapFactory.decodeStream(bookImageURL
                            .openConnection().getInputStream());
                    bitmapArray.add(bitMapImage);
                } catch (IOException e) {
                    // TODO Auto-generated catch block
                    e.printStackTrace();
                    Log.i("BITMAP", "ERROR" + i);
                }
            }
            return null;
        }

        @Override
        protected void onPostExecute(String result) {
            super.onPostExecute(result);

            progressDialog.dismiss();
            txtSearchFor.setText("Results For");
            txtSearchedKeywords.setText("\"" + keyWordsSearch + "\"");
            txtBooksCount.setVisibility(View.VISIBLE);
            txtBooksCount.setText(bitmapArray.size() + " Book(s) found");
            ImageAdapter adapter = new ImageAdapter(getBaseContext(), act);
            listView.setAdapter(adapter);

        }

    }

    public class ImageAdapter extends BaseAdapter {

        public ImageAdapter(Context c) {
            context = c;
        }

        // ---returns the number of images---
        public int getCount() {
            return bitmapArray.size();
        }

        public ImageAdapter(Context ctx, Activity act) {
            inflater = (LayoutInflater) act
                    .getSystemService(Context.LAYOUT_INFLATER_SERVICE);
        }

        // ---returns the ID of an item---
        public Object getItem(int position) {
            return position;
        }

        public long getItemId(int position) {
            return position;
        }

        // ---returns an ImageView view---
        public View getView(int position, View convertView, ViewGroup parent) {

            // ImageView bmImage;

            final ViewHolder holder;
            View vi = convertView;
            if (convertView == null) {
                vi = inflater.inflate(R.layout.list_style, parent, false);
                holder = new ViewHolder();
                holder.txt_BooksTitle = (TextView) vi
                        .findViewById(R.id.txt_searchBookTitle);

                holder.img_BookCoverPhoto = (ImageView) vi
                        .findViewById(R.id.img_searchBookCoverPhoto);
                holder.txt_BooksAuthor = (TextView) vi
                        .findViewById(R.id.txt_searchAutherName);

                holder.ratingBar = (RatingBar) vi
                        .findViewById(R.id.searchRatingbar);

                vi.setTag(holder);
            } else {

                holder = (ViewHolder) vi.getTag();
            }
            holder.txt_BooksTitle.setText(BookTitle.get(position) + "");
            holder.img_BookCoverPhoto.setImageBitmap(bitmapArray.get(position));
            holder.txt_BooksAuthor.setText(BookAuther.get(position) + "");
            holder.ratingBar.setRating(3);
            return vi;
        }
    }

    class ViewHolder {
        TextView txt_BooksTitle;
        TextView txt_BooksAuthor;
        ImageView img_BookCoverPhoto;
        RatingBar ratingBar;
    }
}

Answer 1

Please update below code of item_list.xml file, it will solve your problem.

<?xml version="1.0" encoding="utf-8"?>
<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="match_parent"
    android:layout_height="match_parent" >

    <RelativeLayout
        android:id="@+id/rel_SearchLayout01"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:layout_alignParentLeft="true"
        android:layout_alignParentTop="true" >

        <ImageView
            android:id="@+id/img_searchBookCoverPhoto"
            android:layout_width="70dp"
            android:layout_height="100dp"
            android:layout_margin="5dp"
            android:src="@drawable/ic_launcher" />

        <TextView
            android:id="@+id/txt_searchBookTitle"
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
            android:layout_alignTop="@+id/img_searchBookCoverPhoto"
            android:layout_marginTop="10dp"
            android:layout_toRightOf="@+id/img_searchBookCoverPhoto"
            android:text="The Basic Doctrine Of Islam"
            android:textSize="16sp" />

        <TextView
            android:id="@+id/txt_searchAutherName"
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
            android:layout_below="@+id/txt_searchBookTitle"
            android:layout_marginTop="2dp"
            android:layout_toRightOf="@+id/img_searchBookCoverPhoto"
            android:text="By: Andrew J Newman"
            android:textSize="14sp" />

        <RatingBar
            android:id="@+id/searchRatingbar"
            style="?android:attr/ratingBarStyleSmall"
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
            android:layout_below="@+id/txt_searchAutherName"
            android:layout_marginTop="12dp"
            android:layout_toRightOf="@+id/img_searchBookCoverPhoto"
            android:numStars="5"
            android:rating="5"
            android:stepSize="1" />
    </RelativeLayout>

</RelativeLayout>

Answer 2

What other alternative you can do is in your getView() you can use your ConvertView to implement the OnclickListener like

convertView.(new View.OnClickListener(){

     @Override
     public void onClick(View view) 
    {
      //write your code here
    }
});

do let me know if this alternative works right

public View getView(final int position, View convertView, ViewGroup parent)
    {

            if(convertView == null) /* Create a new row view */
            {
                convertView = inflater.inflate(R.layout.simplerow, null);
            }

        convertView.setOnClickListener(new View.OnClickListener()
            {
                @Override
                public void onClick(View v)
                {
                    //your implementation.
                }
            }


    }

Answer 3

This may work for you.

If you want to have different listeners for different view components, then do like this

sqView.ticker.setOnClickListener(new OnClickListener(){

                    @Override
                    public void onClick(View view) {
                        // TODO Auto-generated method stub
//write your code here
}
});

Answer 4

Add both android:clickable="false" android:focusable="false"

in your item_list.XML

I think problem will solve

Answer 5

Implement OnItemClickListener in your main Activity class.

public class BookSearchResultActivity extends Activity implement OnItemClickListener {

//now implement unimplemented methods 
//and 
listView.setOnItemClickListener(this);
}

I hope, This will help you.

Answer 6

make false clickable and focusable in xml file for all widget in custom ListView