Calling delete this from OnOk in MFC [duplicate]

Question

This question already has answers here:

Closed 8 years ago.

Possible Duplicate:
Should “delete this” be called from within a member method?

Is is correct to call delete from OnOk event handler function, as in the code below.

void CTestDlg::OnOK() 
{
    CDialog::OnOK();

    this->DestroyWindow();
    delete this;
}

Answer 1

I presume you're trying all that because the dialog instance is modeless?

In that case you shouldn't be calling the base class OnOK() from your override, but only DestroyWindow().

If you have to delete this then an override of PostNcDestroy() is the appropriate place.