undefined index: postevent....solved it but that created other problems [closed]

Question

It's difficult to tell what is being asked here. This question is ambiguous, vague, incomplete, overly broad, or rhetorical and cannot be reasonably answered in its current form. For help clarifying this question so that it can be reopened, visit the help center.

Closed 9 years ago.

$citylink_view = "view=$targetview&postevent=$_GET[postevent]";

it was showing undefined index: postevent. i solved it by using

$posteventview = $_GET['postevent'];
$citylink_view = "view=$targetview&".$posteventview;

but this is creating problems in my URL. functionality doesn't working....

Answer 1

Situation before:

$citylink_view = "view=$targetview&postevent=$_GET[postevent]";

which is the same as:

$citylink_view = "view=$targetview&postevent=" . $_GET['postevent'];

Which can be written as:

$foo = $_GET['postevent'];
$citylink_view = "view=$targetview&postevent=" $foo;

You wrote:

$posteventview = $_GET['postevent'];
$citylink_view = "view=$targetview&".$posteventview;

Can you spot the difference?

Aside, you are possible vulnerable to XSS. Sanitize the input and urlencode. Use filter_* functions, e.g.:

$posteventview = filter_input(INPUT_GET, "postevent");
$citylink_view = "view=$targetview&postevent=" . urlencode($posteventview);