Question

Consider a class inside a namespace. The definition of the class declares a friend function.

namespace Foo
{
    class Bar
    {
        friend void baz();
    };
}

This should, based on what I know, declare baz() as a member of the innermost enclosing namespace, i.e. Foo.

Therefore, I expected the following definition for baz() to be correct:

void Foo::baz() { }

However, GCC (4.7) gives me an error.

error: ‘void Foo::baz()’ should have been declared inside ‘Foo’

Several solutions seem to work:

  • Declare baz() outside the class.

    namespace Foo
    {
        void baz();
    
        class Bar
        {
            friend void baz();
        };
    }
    
  • Define baz() inside the namespace.

    namespace Foo
    {
        class Bar
        {
            friend void baz();
        };
    }
    ...
    namespace Foo
    {
        void baz() { }
    }
    
  • Compile with the -ffriend-injection flag, which eliminates the error.

These solutions seem to be inconsistent with the general rules of declaration/definition in C++ I know.

Why do I have to declare baz() twice?
Why is the definition otherwise only legal inside a namespace, and illegal with the scope resolution operator?
Why does the flag eliminate the error?

Was it helpful?

Solution

Why do I have to declare baz() twice?

Because the friend declaration doesn't provide a usable declaration of the function in the namespace. It declares that, if that function is declared in that namespace, it will be a friend; and if you were to define a friend function inside a class, then it would be available via argument-dependent lookup (but not otherwise) as if it were declared in the namespace.

Why is the definition otherwise only legal inside a namespace, and illegal with the scope resolution operator?

Because it hasn't been (properly) declared in the namespace, and a function can only be defined outside its namespace (with scope resolution) if it has been declared.

Why does the flag eliminate the error?

Because the flag causes the friend declaration to act as a declaration in the namespace. This is for compatibility with ancient dialects of C++ (and, apparently, some modern compilers) in which this was the standard behaviour.

OTHER TIPS

The first piece of code should compile:

namespace A {
   struct B {
      friend void foo();
   };
}
void A::foo() {}

Although it that particular function cannot be used unless you also provide a declaration at namespace level. The reason is that friend declarations are only seen through Argument Dependent Lookup (ADL), but foo does not depend on A::B, and thus the compiler will never look inside that type.

Licensed under: CC-BY-SA with attribution
Not affiliated with StackOverflow
scroll top