Question

I need to pass a set of options into a function. Right now I'm putting in a bit of validation to verify things at least make sense. If there any better way to go about doing this? In fact for the last 4 options I would like to check if the array is full of strings rather than just an array but didnt want to loop through the array if I could help it.

public function edit($id, $title, $options, $raw) {
    // Update options
    if (is_array($options)) {
        if (array_key_exists('showTitleDate', $options)) {
            if ($options['showTitleDate'] === true) { $this->showTitleDate = true; }
        }
        if (array_key_exists('showDetail', $options)) {
            if ($options['showDetail'] === true) { $this->showDetail = true; }
        }
        if (array_key_exists('showDetailDate', $options)) {
            if ($options['showDetailDate'] === true) { $this->showDetailDate = true; }
        }
        if (array_key_exists('showSubdetail', $options)) {
            if ($options['showSubdetail'] === true) { $this->showSubdetail = true; }
        }
        if (array_key_exists('showSubdetailDate', $options)) {
            if ($options['showSubdetailDate'] === true) { $this->showSubdetailDate = true; }
        }
        if (array_key_exists('showAdditional', $options)) {
            if ($options['showAdditional'] === true) { $this->showAdditional = true; }
        }
        if (array_key_exists('showTitleSelect', $options)) {
            if ($options['showTitleSelect'] === true) { $this->showTitleSelect = true; }
        }
        if (array_key_exists('showTopSelect', $options)) {
            if ($options['showTopSelect'] === true) { $this->showTopSelect = true; }
        }
        if (array_key_exists('showMiddleSelect', $options)) {
            if ($options['showMiddleSelect'] === true) { $this->showMiddleSelect = true; }
        }
        if (array_key_exists('showBottomSelect', $options)) {
            if ($options['showBottomSelect'] === true) { $this->showBottomSelect = true; }
        }
        if (array_key_exists('placeholderTitle', $options)) {
            if (is_string($options['placeholderTitle'])) { $this->placeholderTitle = $options['placeholderTitle']; }
        }
        if (array_key_exists('placeholderTitleDate', $options)) {
            if (is_string($options['placeholderTitleDate'])) { $this->placeholderTitleDate = $options['placeholderTitleDate']; }
        }
        if (array_key_exists('placeholderDetail', $options)) {
            if (is_string($options['placeholderDetail'])) { $this->placeholderDetail = $options['placeholderDetail']; }
        }
        if (array_key_exists('placeholderDetailDate', $options)) {
            if (is_string($options['placeholderDetailDate'])) { $this->placeholderDetailDate = $options['placeholderDetailDate']; }
        }
        if (array_key_exists('placeholderSubdetail', $options)) {
            if (is_string($options['placeholderSubdetail'])) { $this->placeholderSubdetail = $options['placeholderSubdetail']; }
        }
        if (array_key_exists('placeholderSubdetailDate', $options)) {
            if (is_string($options['placeholderSubdetailDate'])) { $this->placeholderSubdetailDate = $options['placeholderSubdetailDate']; }
        }
        if (array_key_exists('placeholderAdditional', $options)) {
            if (is_string($options['placeholderAdditional'])) { $this->placeholderAdditional = $options['placeholderAdditional']; }
        }
        if (array_key_exists('optionsTitleSelect', $options)) {
            if (is_array ($options['optionsTitleSelect'])) { $this->optionsTitleSelect = $options['optionsTitleSelect']; }
        }
        if (array_key_exists('optionsTopSelect', $options)) {
            if (is_array ($options['optionsTopSelect'])) { $this->optionsTopSelect = $options['optionsTopSelect']; }
        }
        if (array_key_exists('optionsMiddleSelect', $options)) {
            if (is_array ($options['optionsMiddleSelect'])) { $this->optionsMiddleSelect = $options['optionsMiddleSelect']; }
        }
        if (array_key_exists('optionsBottomSelect', $options)) {
            if (is_array ($options['optionsBottomSelect'])) { $this->optionsBottomSelect = $options['optionsBottomSelect']; }
        }
    }

    // -- logic code here
}
Was it helpful?

Solution

Make a mapping of all available options to their validation function. I wrapped the standard functions as example for own functions.

public function edit($id, $title, $options, $raw) {
    $isString = function($value) {
        return is_string($value);
    };
    $isArray = function($value) {
        return is_array($value);
    };
    $avaiableOptions = array(
        'placeholderTitleDate' => $isString,
        'optionsBottomSelect' => $isArray,
        ...
    );
    foreach ($options as $key => $val) {
        if (!array_key_exists($key, $availableOptions) {
            echo ... no such option - typo? available options are: ...
        } else {
            $validationFunc = $availableOptions[$key];
            if (!$validationFunc($options[$key])) {
                echo ... invalid value for option $key
            }
        }
    }

OTHER TIPS

My php is rusty, but I think "indirection" might help here:

$all_key = array('showTitleDate', 'showDetail' /*, ... */);
foreach ($all_key as $k)
    if (array_key_exists($k, $options) && $options[$k] === true) {
        $this->$k = true;
    }
}
Licensed under: CC-BY-SA with attribution
Not affiliated with StackOverflow
scroll top