Inside
void Board::CreateBoard()
you have declared a local variable char Board[BoardSize][BoardSize]
that you are fillng with -
.
But in your
void Board::PrintBoard()
I think you are calling the char Board[MAX_SIZE][MAX_SIZE]
defined in the class.
So, you are setting a local variable and printing the class variable that you have not set, hence the weird output.