Android: nullPointerException when using Parcelable interface in class with ArrayList<customObject>

StackOverflow https://stackoverflow.com/questions/20804502

  •  22-09-2022
  •  | 
  •  

Domanda

I am trying to make the class called Music use parcelable so I can access an instance of Music in two different activities. I don't want to use serializable for speed purposes. I keep getting a nullPointerException when I try to pass it using:

Intent in = getIntent();
thisInstance = (Music) in.getExtras().get("MusicInstance");

Music Class: (the ArrayList is at the top and parcelable classes at the bottom)

public class Music implements Parcelable{

    private static ArrayList<genericSongClass> songs = new ArrayList<genericSongClass>();

    Cursor cursor;

    static Context context;

    public Music(Context context){
        this.context = context;
    }

    public Music(Parcel in){
        in.readTypedList(songs, genericSongClass.CREATOR);
    }

    public void BindAllSongs() {        
            /** Making custom drawable */
            String selection = MediaStore.Audio.Media.IS_MUSIC + " != 0";
            final String[] projection = new String[] {
                    MediaStore.Audio.Media.DISPLAY_NAME,
                    MediaStore.Audio.Media.ARTIST,
                    MediaStore.Audio.Media.DATA,
                    MediaStore.Audio.Media.ALBUM};
                    final String sortOrder = MediaStore.Audio.AudioColumns.TITLE
                            + " COLLATE LOCALIZED ASC";

                    try {
                        // the uri of the table that we want to query
                        Uri uri = android.provider.MediaStore.Audio.Media.EXTERNAL_CONTENT_URI;
                        // query the db
                        cursor = context.getContentResolver().query(uri,
                                projection, selection, null, sortOrder);
                        if (cursor != null) {
                            songs = new ArrayList<genericSongClass>(cursor.getCount());
                            cursor.moveToFirst();                       
                            while (!cursor.isAfterLast()) { 
                                genericSongClass GSC = new genericSongClass();
                                GSC.songTitle = cursor.getString(0);
                                GSC.songArtist = cursor.getString(1);   
                                GSC.songData = cursor.getString(2);
                                GSC.songAlbum = cursor.getString(3);
                                songs.add(GSC);
                                cursor.moveToNext();
                            }
                        }
                    } catch (Exception ex) {

                    } finally {
                        if (cursor != null) {
                            cursor.close();
                        }
                    }       

        }

    public static Object[] toArray(ArrayList<Object> list){
        Object[] toReturn = new Object[list.size()];
        for (int i = 0; i < list.size(); i++){
            toReturn[i] = list.get(i);
        }
        return toReturn;
    }

    public ArrayList<String> getArtists(){
        ArrayList<String> artists = new ArrayList<String>();
        for(genericSongClass gsc: songs){
            if(!artists.contains(gsc.songArtist)){
                artists.add(gsc.songArtist);
            }
        }
        Alphabetize forArtists = new Alphabetize(artists);
        return forArtists.getSortedArrayList();
    }

    public ArrayList<String> getAlbums(String artist){
        ArrayList<String> albums = new ArrayList<String>();
        for(genericSongClass gsc: songs){
            if(gsc.songArtist == artist){
                albums.add(gsc.songAlbum);
            }
        }
        Alphabetize forAlbums = new Alphabetize(albums);
        return forAlbums.getSortedArrayList();
    }

    //--- Parcel ------------------------------------------------

     public static final Parcelable.Creator<Music> CREATOR = new Parcelable.Creator<Music>() {  

            public Music createFromParcel(Parcel in) {  
                return new Music(in);  
            }

            @Override
            public Music[] newArray(int size) {
                return new Music[size];
            }  
        };

    @Override
    public int describeContents() {
        return 0;
    }

    @Override
    public void writeToParcel(Parcel dest, int flags) {
        dest.writeList(songs);
    }



}

genericSongClass:

public class genericSongClass implements Parcelable {
    String songTitle = "";
    String songArtist = "";
    String songData = "";
    String songAlbum = "";

    public genericSongClass(){};

    private genericSongClass(Parcel in){
        songTitle = in.readString();
        songArtist = in.readString();
        songData = in.readString();
        songAlbum = in.readString();
    }

    public static final Parcelable.Creator<genericSongClass> CREATOR = new Parcelable.Creator<genericSongClass>() {

        @Override
        public genericSongClass createFromParcel(Parcel source) {
            return new genericSongClass(source);
        }

        @Override
        public genericSongClass[] newArray(int size) {
            return new genericSongClass[size];
        }

    };

    @Override
    public int describeContents() {
        return 0;
    }

    @Override
    public void writeToParcel(Parcel dest, int flags) {
        dest.writeString(songTitle);
        dest.writeString(songArtist);
        dest.writeString(songData);
        dest.writeString(songAlbum);
    }
}

Why am I getting the nullpointer and how do I remedy the situation?

This is my first time using Parcelable, so any help/advice is more than welcome. Thanks in advance!

È stato utile?

Soluzione

initialize your list into constructor.use following code please.

public Music(Parcel in){
        songs = new ArrayList<genericSongClass>();
        in.readTypedList(songs, genericSongClass.CREATOR);
    }

and get with this code:

thisInstance = getIntent().getParcelableExtra("MusicInstance");

and make sure you initialize thisInstance.

Altri suggerimenti

getParcelableArrayListExtra , getParcelableExtra 

as well as

putParcelableArrayListExtra , putExtra(String name, Parcelable value)

are used to pass Parcelable's through intents.

Autorizzato sotto: CC-BY-SA insieme a attribuzione
Non affiliato a StackOverflow
scroll top