Empty <li> appears after every normal <li> [closed]

Question

This question is unlikely to help any future visitors; it is only relevant to a small geographic area, a specific moment in time, or an extraordinarily narrow situation that is not generally applicable to the worldwide audience of the internet. For help making this question more broadly applicable, visit the help center.

Closed 8 years ago.

I'm creating an unordered list with PHP. The list is outputting fine, just as expected. However, after every list item, an extra, empty list item appears. I can't figure out why this is happening. There's really nothing else to explain or elaborate on.

Here's the code:

    echo '      <div><ul>';
    $i=0;
    while($i<$length && $i<$amount) {
        do {
            $id = rand(0, $amount-1);
        } while(($priority[$id] > $cur_prior || $used[$id]));

        do { $cur_prior++; } while(!in_array($cur_prior, $priority) && $cur_prior <= max($priority));

        if(!$used[$id]) {
            $cur_views = $views[$id]+1;
            $cur_id = $ids[$id];
            mysql_query("   UPDATE table SET views = '$cur_views'
                            WHERE id = '$cur_id'")
                or die('Database error.');

            $used[$id] = true;

            echo '  <li><a href="'.$ids[$id]).'/'.$url[$id].'" target="_blank">
                        <img src="'.$img['main']['folder'].$img[$id].'?'.time().'" alt="'.$name[$id].'" title="'.$name[$id].'">
                    </a><li>';

            $i++;
        }
    }
    echo '      </ul></div>';

Hope someone can help, thanks :)

Answer 1

your echo statement doesn't close li, it creates a new li

Try this instead:

echo '  <li><a href="'.ids[$id]).'/'.$aurl[$id].'" target="_blank">
    <img src="'.$img['main']['folder'].$img[$id].'?'.time().'" alt="'.$name[$id].'" title="'.$name[$id].'">
    </a></li>'; // fixed this line

Answer 2

Your problem is on the

echo

echo '  <li><a href="'.ids[$id]).'/'.$aurl[$id].'" target="_blank">
                    <img src="'.$img['main']['folder'].$img[$id].'?'.time().'" alt="'.$name[$id].'" title="'.$name[$id].'">
                </a><li>';

you don't close the <li> you have to close it </li>