I suggest method is model.
in addresss.rb
def formatted_address
fa = ""
fa += primary_street ? primary_street + ' | ' : ""
fa += secondary_street ? secondary_street + ' | ' : ""
fa += city ? city + ', ' : ""
fa += region ? region : ""
fa += postal_code ? ' ' + postal_code : ""
fa
end
in view(you don't need to check @site.addresses isNil or isEmpty, because in this case not iterate)
<% @site.addresses.each do |address| %>
<p><%= address.formatted_address %></p>
<% end %>