Error when calling insertionsort method and how to print an arraylist

Question

I have created a program which stores temperature(double) and day(string) in an arraylist, then uses the comparable interface and an insertion sort to sort the arraylist. Now all that i have left is calling the insertion sort method and print out the original order of the arraylist and the sorted order. However when I call the insertionsort method it gives me an error stating "invalid method declaration; return type required". Why am i receiving this error? Also is my print statement correct to print out the original arraylist? How would i update it to print out the sorted arraylist? Or can i print that out from the insertionsort method?

Here is my code:

import java.io.*;
import java.util.Scanner;
import java.util.Arrays;
import java.util.ArrayList;


public class DailyTemperature implements Comparable<DailyTemperature>
{
     //variables
    private Double temperature;
    private String day;

    //getTemp & setTemp methods
    public double getTemp()
    {
      return temperature;
    }

    public void setTemp(double newTemp)
    {
      temperature = newTemp;
    }

    //getDay & setTEmp methods
    public String getDay()
    {
      return day;
    }

    public void setDay(String newDay)
    {
      day = newDay;
    }


    public DailyTemperature(String day, double temperature) 
    {
      this.day = day;
      this.temperature = temperature;
    }

    public int compareTo(DailyTemperature other) 
    {
        if (temperature < other.temperature) return -1;
        if (temperature == other.temperature) return 0;
        return 1;
    }

    public String toString() 
    {
        return("Day of Week" + this.getDay() +
        "Temperature" + this.getTemp());
    }


}



import java.io.*;
import java.util.Scanner;
import java.util.ArrayList;

public class DailyTemperatureList 
{
    public static void main (String [] args) 
    {

    ArrayList<DailyTemperature> dailytemps = new ArrayList<DailyTemperature>();

    dailytemps.add(new DailyTemperature("Mon", 87.1));
    dailytemps.add(new DailyTemperature("Tue", 88.3));
    dailytemps.add(new DailyTemperature("Wed", 81.2));
    dailytemps.add(new DailyTemperature("Thu", 84.0));
    dailytemps.add(new DailyTemperature("Fri", 76.3));
   }

   public static <DailyTemperature extends Comparable<? super DailyTemperature>>
   void insertionSort(ArrayList<DailyTemperature> dailytemps)
   {
       DailyTemperature temp = null;
       int position = 0;

       //loop from 2nd element on
       for (int i = 1; i < dailytemps.size(); i++)
       {
           temp = dailytemps.get(i);
           position = i;

           while ( 0 < position && temp.compareTo(dailytemps.get(position - 1 )) < 0)
           {
               dailytemps.set(position, dailytemps.get(position - 1));
               position--;
           }
            dailytemps.set(position,temp);
        }
    }

    insertionSort(ArrayList<DailyTemperature> dailytemps);
    System.out.println( dailytemps.toString() );





}

Answer 1

However when I call the insertionsort method it gives me an error stating "invalid method declaration; return type required". Why am i receiving this error?

You are calling insertionSort() inside DailyTemperatureList class but outside any method which does not compile. I moved the call into main() method, so that it compiles, see bellow.

Also is my print statement correct to print out the original arraylist? How would i update it to print out the sorted arraylist? Or can i print that out from the insertionsort method?

Print out the original list before calling insertionSort(), and after sorting it print out the sorted list:

System.out.println( "original list:" );
System.out.println( dailytemps.toString() );

insertionSort( dailytemps);
System.out.println( "sorted list:" );

Output:

original list: [Day of WeekMonTemperature87.1, Day of WeekTueTemperature88.3, Day of WeekWedTemperature81.2, Day of WeekThuTemperature84.0, Day of WeekFriTemperature76.3] 

sorted list: [Day of WeekFriTemperature76.3, Day of WeekWedTemperature81.2, Day of WeekThuTemperature84.0, Day of WeekMonTemperature87.1, Day of WeekTueTemperature88.3]

Corrected DailyTemperatureList class:

import java.io.*;
import java.util.Collections;
import java.util.Scanner;
import java.util.ArrayList;

public class DailyTemperatureList
{
  public static void main (String [] args)
  {

    ArrayList<DailyTemperature> dailytemps = new ArrayList<DailyTemperature>();

    dailytemps.add(new DailyTemperature("Mon", 87.1));
    dailytemps.add(new DailyTemperature("Tue", 88.3));
    dailytemps.add(new DailyTemperature("Wed", 81.2));
    dailytemps.add(new DailyTemperature("Thu", 84.0));
    dailytemps.add(new DailyTemperature("Fri", 76.3));

    System.out.println( "original list:" );
    System.out.println( dailytemps.toString() );

    insertionSort( dailytemps);
    System.out.println( "sorted list:" );
    System.out.println( dailytemps.toString() );



  }

  //public static <DailyTemperature extends Comparable<? super DailyTemperature>>
  static void insertionSort(ArrayList<DailyTemperature> dailytemps)
  {
    DailyTemperature temp = null;
    int position = 0;

    //loop from 2nd element on
    for (int i = 1; i < dailytemps.size(); i++)
    {
      temp = dailytemps.get(i);
      position = i;

      while ( 0 < position && temp.compareTo(dailytemps.get(position - 1 )) < 0)
      {
        dailytemps.set(position, dailytemps.get(position - 1));
        position--;
      }
      dailytemps.set(position,temp);
    }
  }






}