How can I refine this Javascript code so it IGNORES links from images

Question

This is a variation of an existing question

{Please note - this question is the opposite/inverse of an existing StackOverflow question that is too complex to answer there}

From the very beginning

I want to make some refinement to some code from this challenge:

// the new base url
var base = ' https://www.example.co.uk/gp/wine/order?ie=UTF8&asin=';
var links  = document.getElementsByTagName('a');

for(var i = 0;i < links.length;i++){
    // check each link for the 'asin' value
    var result = /asin=([\d\w]+)/.exec(links[i].getAttribute('href'));
    if(result){
        // make a new url using the 'base' and the 'asin' value
        links[i].setAttribute('href', base+result[1]);
    }
}

Now, instead of it acting on all links, can I get it to only look at links that are from text?

Here is an HTML snippet to show what I mean:

<a href="/shop/product?ie=UTF8&amp;asin=Z00FDLN878&amp;tab=UK_Default" target="_blank"><img width="125" height="125" border="0" src="http://ecx.images-amazon.com/images/I/01W9a7gwosL.jpg" alt="43453"></a>

That's an image link - I do NOT want it to act on that.

Answer 1

In straight javascript / DOM, test the links as you loop through them:

var base        = 'https://www.example.co.uk/gp/wine/order?ie=UTF8&asin=';
var linksNoImg  = document.querySelectorAll ("a[href*='asin']");

for (var J = linksNoImg.length - 1;  J >= 0;  --J) {
    var imgLink = linksNoImg[J];

    //--- Make sure it's not an image link:
    if ( ! imgLink.querySelector ('img') ) {
        //--- Check each link for the 'asin' value
        var result  = /asin=([\d\w]+)/.exec (imgLink.getAttribute ('href') );
        if (result) {
            // make a new url using the 'base' and the 'asin' value
            imgLink.setAttribute ('href', base+result[1]);
        }
    }
}

jQuery lets you preselect only the correct links:

//--- The new base URL
var base        = ' https://www.example.co.uk/gp/wine/order?ie=UTF8&asin=';
var linksNoImg  = $("a[href*='asin']:not(:has(img))");

linksNoImg.each ( function () {
    // check each link for the 'asin' value
    var result = /asin=([\d\w]+)/.exec(links[i].getAttribute('href'));
    if(result){
        // make a new url using the 'base' and the 'asin' value
        links[i].setAttribute('href', base+result[1]);
    }
} );

But this requires you to load jQuery in Greasekit -- which is well worth it for any but the simplest scripts.

Answer 2

if (links[i].querySelector('img')) {
    // Link has an <img>! Oh no!
}

To support older browsers, call getElementsByTagName() instead (and check for an empty array).