java.sql.SQLException: ORA-01704: string literal too long When Insert Or Update

Question 1

You're getting this error because your SQL statement (which is the result of this statement:

 insertUpdate = "INSERT INTO ip_discharge (DISCHARGE_ID,ADMISSION_NO , reg_no, DISCHARGE_TEXT , specialization_no , CRITICAL_FLAG , ENTERED_BY , COMPANY_NO, mode_of_discharge, referred_to "
                        + ")values('"+ PK_NO+ "','"+ ADMISSION_NO+ "','"+ REG_NO+ "','" + DISCHARGE_TEXT + "'," + specialization_no + ",'" + CRITICAL_FLAG + "','" + ENTERED_BY + "','" + COMPANY_NO + "','" + mode_of_discharge + "','" + referred_to + "')";
            }

is getting too long.

Building your SQL statement in this way (by concatenating variable values together) is a very bad idea because

it negatively impacts performance (you force the database to parse a new statement every time)
it allows SQL injection attacks
it limits the amount of data you can insert because your SQL statement must not exceed 4000 characters in length

Solution: use a Prepared Statement with bind variables instead

Question 2

In your SQL editor run update or insert query by putting static value and check are yo getting error there.

Question 3

You have to specify DISCHARGE_TEXT CLOB(64 K) or something like as per your requirement. See this defination.

CLOB data type

A CLOB (character large object) value can be up to 2,147,483,647 characters long. A CLOB is used to store unicode character-based data, such as large documents in any character set.

The length is given in number characters for both CLOB, unless one of the suffixes K, M, or G is given, relating to the multiples of 1024, 1024*1024, 1024*1024*1024 respectively.

Length is specified in characters (unicode) for CLOB.

Question 4

i just solve this problem to change SQL Statement to Prepared Statement

here is my new sql code

public Long addPatientDischargeValue(String CRITICAL_FLAG , String DISCHARGE_TEXT ,String ADMISSION_NO , String REG_NO ,Integer specialization_no,String ENTERED_BY, String COMPANY_NO, String UPDATE_BY, Date UPDATED_TIMESTAMP,String mode_of_discharge, String referred_to) { Long rowInserted=(long) 0;

        boolean fg = true;
        con = dbc.connectDB();

        if (con == null) {
            fg = false;
        }
        if (fg) {
            try {
                Date today = new Date();
                st = con.createStatement();
                String countQry = "SELECT COUNT(ADMISSION_NO) COUNT FROM IP_DISCHARGE WHERE ADMISSION_NO='"
                        + ADMISSION_NO + "'";

                int countNo= 0;
                ResultSet rsCount=st.executeQuery(countQry);
                if(rsCount.next()){
                    countNo = rsCount.getInt("COUNT");
                }

                String insertUpdate = null;
                String Pk_No="";
                if (countNo > 0) {

                insertUpdate=   "update ip_discharge set  " +
                    "update_by = ?,  " +
                    "updated_timestamp = ? , " +
                    "critical_flag = ? , " +
                    "discharge_text = ?,  " +
                    "mode_of_discharge = ? , " +
                    "referred_to = ?  " +
                    "where  admission_no = ?  ";
                PreparedStatement preparedStatement = con.prepareStatement(insertUpdate);

                preparedStatement.setString(1, UPDATE_BY);
                preparedStatement.setDate(2, new java.sql.Date(today.getTime()));
                preparedStatement.setString(3, CRITICAL_FLAG);
                preparedStatement.setString(4, DISCHARGE_TEXT);
                preparedStatement.setString(5, mode_of_discharge);
                preparedStatement.setString(6, "referred_to");
                preparedStatement.setString(7, ADMISSION_NO);

                    // execute update SQL stetement
                preparedStatement.executeUpdate();


                } else {
                    Pk_No = generatedSequence("","SEQ_PATTYPEDTL", "D", "1", "Y");
                    insertUpdate = "INSERT INTO ip_discharge (DISCHARGE_ID,ADMISSION_NO , reg_no, DISCHARGE_TEXT , specialization_no , CRITICAL_FLAG , ENTERED_BY , COMPANY_NO, mode_of_discharge, referred_to "
                            + ")values(?,?,?,?,?,?,?,?,?,?)";

                PreparedStatement preparedStatement = con.prepareStatement(insertUpdate);

                preparedStatement.setString(1, Pk_No);
                preparedStatement.setString(2, ADMISSION_NO);
                preparedStatement.setString(3, REG_NO);
                preparedStatement.setString(4, DISCHARGE_TEXT);
                preparedStatement.setInt(5, specialization_no);
                preparedStatement.setString(6, CRITICAL_FLAG);
                preparedStatement.setString(7, ENTERED_BY);
                preparedStatement.setString(8, COMPANY_NO);
                preparedStatement.setString(9, mode_of_discharge);
                preparedStatement.setString(10, referred_to);
                preparedStatement.executeUpdate();

                System.out.println(insertUpdate);
            }

            } catch (Exception ex) {
                ex.printStackTrace();
            } finally {
                try {
                    st.close();
                    con.close();
                } catch (SQLException ex) {
                    ex.printStackTrace();
                }
            }
        }

        return rowInserted;
    }