mysqli fetch array displays only the first row

Question

I have written this code:

require("config.php");

$rows = array();

$query = "SELECT accountname, bill_city, bill_code, bill_country,  bill_street, latitude, longitude, setype FROM vtiger_accountbillads, vtiger_account, vtiger_geocoding WHERE accountaddressid = accountid AND accountid = crmid";

$result = mysqli_query($connection, $query);

$rows_number = $result->num_rows;
echo $rows_number . "<br/><br/>";

$row = mysqli_fetch_array($result);

if($result->num_rows > 0){
    for($i=0; $i < $rows_number; $i++) {
            $rows[] = array("name" => $row[0],
                        "city" => $row[1],
                        "code" => $row[2],
                        "country" => $row[3],
                        "street" => $row[4],
                        "latitude" => $row[5],
                        "longitude" => $row[6],
                        "type" => $row[7]);
    }
}

$json = json_encode($rows);
print $json;

mysqli_free_result($row);
mysqli_close($connection);

I'm trying to fetch several data using the query written in the code above, but it displays the first row 47 times. Why? What am I doing wrong? Thanks!

Answer 1

You need to iterate through the result set returned by MySQL. That means calling mysqli_fetch_array() for each row of that result set. You can do that using a while loop:

while($row = mysqli_fetch_assoc($result)) {
    $rows[] = array("name"      => $row['name'],
                    "city"      => $row['bill_city'],
                    "code"      => $row['bill_code'],
                    "country"   => $row['bill_country'],
                    "street"    => $row['bill_street'],
                    "latitude"  => $row['latitude'],
                    "longitude" => $row['longitude'],
                    "type"      => $row['setype']);
    }
}

Answer 2

Don't use for loop for fetching SQL queries. Use while instead:

if($result->num_rows > 0){
    while($row = mysqli_fetch_assoc($result))
    {
        $rows[] = array("name" => $row[0],
                        "city" => $row[1],
                        "code" => $row[2],
                        "country" => $row[3],
                        "street" => $row[4],
                        "latitude" => $row[5],
                        "longitude" => $row[6],
                        "type" => $row[7]);
    }
}