Is it not good practice to collect list of roles in HttpGet method?
There's nothing wrong with it.
Is there some change that i need to make in my controller or test method in order make the test pass?
Yes, you could add an app.config file to your unit test project and register a role manager in the <system.web>
section, the same way you did in your actual application. Otherwise where do you think the Roles.GetAllRoles();
method will get any data from? Alternatively you could wrap this call in a service layer that could be mocked in your unit test.
Is the error occurring because I'm using RhinoMock?
No.