setVisible() efficiency

Question

I was wondering, would it be more efficient to do something like this:

   setVisible(false) // if the component is invisible

or like this:

   if(isVisible()){
      setVisible(false)
   }

Answer 1

This has nothing to do with efficiency. Use the first one, it's simpler and probably already contains the visibility check inside the setVisible() method.

When you write code, don't try to think about efficiency, especially in ridiculously trivial cases like this. You're running on a multi GHz computer, so you're only wasting your time on micro-optimization like this.

Answer 2

setVisible() as implemented by JComponent already calls isVisible() so it's not more efficient to add a redundant call. In any case, it would be really improbable that it would be any kind of a performance bottle neck.

Answer 3

The only case in which your second example would make sense, is in a case of switching visibility on and off.

if(isVisible()){
   setVisible(false);
}else{
   setVisible(true);
}